perf(render): reuse serialized viewer ids#68
Merged
Conversation
Arbousier1
force-pushed
the
codex/perf-render-viewer-serialization
branch
from
July 16, 2026 07:39
d679e16 to
cf0d497
Compare
TypeThe0ry
marked this pull request as ready for review
July 16, 2026 08:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pure performance scope
This candidate changes only
TableRenderSnapshotFactoryviewer-ID preprocessing and an exact behavior-preservation test. It does not include the closed #57 occupied-seat optimization and does not change game rules, visibility policy, packet behavior, timers, interactions, or supported platforms.Candidate
Each distinct viewer UUID is serialized exactly once per
create()call into a private(UUID id, String serializedId)record. The records are sorted byserializedId, preserving the existingComparator.comparing(UUID::toString)order exactly. Membership signatures append the cached strings, while exclusion lists retain the original UUID objects and ordering.The test covers:
UUID.compareToordering differs from its serialized string orderingEvidence policy
No performance claim is made from source inspection. GitHub Build/Test must pass before the trusted base-owned
snapshotA/B gate is enabled. OnlyPASS_OPTIMIZEDpermits readying and expected-head squash merge; inconclusive or regressed evidence closes the candidate without merge.No Gradle, JMH, test, or server workload was run locally.